Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize minor fixes #1238

Open
wants to merge 9 commits into
base: modularize
Choose a base branch
from
Open

Modularize minor fixes #1238

wants to merge 9 commits into from

Conversation

SamErde
Copy link
Collaborator

@SamErde SamErde commented Nov 28, 2024

A few code quality updates:

  • Fix spelling and typos
  • Add missing catch blocks
  • Add missing begin/end blocks
  • Add missing OutputType
  • Remove extra whitespace
  • Remove improper trailing commas in JSON

@SamErde SamErde requested a review from a team as a code owner November 28, 2024 16:06
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit f5877f3:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.build.ps1 ✅Succeeded
module_legacy/docfx.json ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAdministrativeUnit.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAdministrativeUnitMember.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAttributeSet.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAuditDirectoryLog.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAuditSignInLog.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraCustomSecurityAttributeDefinition.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraCustomSecurityAttributeDefinitionAllowedValue.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraFeatureRolloutPolicy.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraObjectSetting.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Remove-EntraPolicy.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Set-EntraPolicy.ps1 ✅Succeeded
module_legacy/EntraBeta/AdditionalFunctions/Get-EntraBetaApplicationPasswordCredential.ps1 ✅Succeeded
module_legacy/EntraBeta/AdditionalFunctions/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Set-EntraBetaDirSyncFeature.ps1 ✅Succeeded
src/CompatibilityAdapterBuilder.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

SteveMutungi254
SteveMutungi254 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@SteveMutungi254 SteveMutungi254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteveMutungi254 SteveMutungi254 added Ready For Review The PR Ready for Review P0 Highest priority labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMutungi254 SteveMutungi254 SteveMutungi254 approved these changes

Assignees
No one assigned
Labels
P0 Highest priority Ready For Review The PR Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamErde @SteveMutungi254